-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug when sequence units level appear after tapping back #260
fix: bug when sequence units level appear after tapping back #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make changes while considering the COURSE_NESTED_LIST_ENABLED
flag, accounting for both true and false values.
Previously, it functioned correctly with the false
value, but now it operates with the true
value. Let's account for both scenarios this time. 😄
@HamzaIsrar12 so, when COURSE_NESTED_LIST_ENABLED = false when an user clicks the resume button the next content will be opened and then when he goes back the list of units should appear? Don't think this is a good behaviour...thoughts? |
@dixidroid |
96269ed
to
76b6615
Compare
@HamzaIsrar12 I've added an ability to use the COURSE_NESTED_LIST_ENABLED flag |
76b6615
to
90344a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏎️ ✨
@@ -168,14 +168,24 @@ class CourseOutlineFragment : Fragment() { | |||
viewModel.resumeSectionBlock?.let { subSection -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also move this and the other block (in DatesFragment) to their respective ViewModel, but that's up to you now. 😄
Removed sequence units level when open a content from Resume or Dates