fix: Analytics events improvements & Add missing ones #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dashboard/src/main/java/org/openedx/learn/presentation/LearnFragment.kt
dixidroid
force-pushed
the
hamza/LEARNER-10192
branch
from
db969a1 to
f2ea984
Compare
| private val config: Config, | ||
| private val dashboardRouter: DashboardRouter, | ||
| private val analytics: DashboardAnalytics, | ||
| ) : BaseViewModel() { | ||
| private val _uiState = MutableStateFlow( | ||
| LearnUIState( | ||
| if (openTab == LearnTab.PROGRAMS.name) { |
There was a problem hiding this comment.
What do you think about using valueOf to convert a string to an enum instead of using if?
volodymyr-chekyrta
previously approved these changes
Nov 18, 2024
|
@dixidroid, please resolve conflicts |
# Conflicts: # course/src/test/java/org/openedx/course/presentation/container/CourseContainerViewModelTest.kt
volodymyr-chekyrta
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have removed the extra space after the colon in Payment Events, ensuring consistency with the other analytics.