-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash current must not be NaN during bulk download #412
fix: crash current must not be NaN during bulk download #412
Conversation
Thanks for the pull request, @dixidroid! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @dixidroid! Are you contributing as an individual, or on behalf of an organization? |
hi @mphilbrick211! I'm a 2U member and someone removed my email from the Edx organization. I've already created an issue here - openedx/axim-engineering#1317 but still waiting...not sure how long it will take. |
Hi @dixidroid! You can have your manager reach out to [email protected] as well. Your manager can ask that you be added to our existing 2U agreement. |
72bfbed
to
614c586
Compare
- Add validation to ensure that the progress value is not NaN. fixes: LEARNER-10248
614c586
to
afa457c
Compare
Hi @mphilbrick211! I was added to the edX org. Do you know how to rerun the openedx/cla check? |
@dixidroid - you should be able to re-run them and the CLA check should turn green. If you try again and it's not working, let me know! |
Description
LEARNER-10248
Fix crash of
IllegalArgumentException - current must not be NaN
during bulk download.Steps to reproduce (specific courses)
Variant-1
Quantum Mechanics for Scientists and Engineers 1
Variant-2
Quantum Mechanics for Scientists and Engineers 1
section
from the Home tab, and the action leads the app to the crash.