Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion's user profile #69

Merged

Conversation

PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Oct 9, 2023

Added screen of another user profile, with an option to open it from the discussion screen.
Full name and year of birth are displayed only for staff members.

Below are scenarios of what a profile might look like:

  • Learner viewing user profile without bio
    Screenshot 2023-10-09 at 19 31 36
  • Learner viewing user profile with bio
    Screenshot 2023-10-09 at 19 31 59
  • Staff user viewing user profile with bio
    Screenshot 2023-10-09 at 19 32 53

@volodymyr-chekyrta volodymyr-chekyrta changed the title Another user profile Discussion's user profile Oct 10, 2023
@volodymyr-chekyrta volodymyr-chekyrta linked an issue Oct 10, 2023 that may be closed by this pull request
@marcotuts
Copy link
Contributor

Would you mind adding some descriptors between each for the images for the sake of clarity? My guess at the headings below for example:

  • Learner viewing User without bio
  • Learner viewing User with bio
  • Staff user viewing User with bio

@volodymyr-chekyrta
Copy link
Contributor

Thanks @marcotuts 🙌
Description is updated.

@marcotuts
Copy link
Contributor

No other product / design feedback thanks!

@PavloNetrebchuk PavloNetrebchuk force-pushed the feature/anothers_account branch from b198bf2 to c9d71f4 Compare October 13, 2023 09:38
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 13, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@volodymyr-chekyrta volodymyr-chekyrta merged commit 0557842 into openedx:develop Oct 13, 2023
1 check passed
@openedx-webhooks
Copy link

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/anothers_account branch October 13, 2023 09:53
k1rill pushed a commit to touchapp/openedx-app-android that referenced this pull request Dec 11, 2024
feat: Added offline support for CourseEnrollmentDetails API

- Store API response in DB for offline mode

fix: LEARNER-10282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

View discussion profile [Android]
4 participants