-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/app update #79
Feature/app update #79
Conversation
# Conflicts: # app/src/main/java/org/openedx/app/di/ScreenModule.kt
Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
92550c8
to
32a2023
Compare
Thanks @PavloNetrebchuk! The feature looks good to me. I did notice some variation in the shades of blue used for accent color and accent text color in dark mode. It might be a compression artifact with the screenshot, can you confirm if they match the correct values in the build? |
32a2023
to
3ac8dd0
Compare
Hello @sdaitzman |
# Conflicts: # app/src/main/java/org/openedx/app/AppRouter.kt # app/src/main/java/org/openedx/app/di/AppModule.kt # app/src/main/java/org/openedx/app/di/ScreenModule.kt # auth/src/main/java/org/openedx/auth/presentation/signin/SignInFragment.kt
Thank you! That looks right to me |
551553e
to
0777de9
Compare
@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Update required:
If a user is not logged in.
If a user is logged in.
Account settings. The item labeled as "version" can be clicked. Navigation buttons are inactive.
Update recommended:
The discovery screen displays a large dialog.
Users will see small clickable dialog boxes on the discovery and dashboard screens.
The button on the profile screen is clickable
Up to date:
Also, it perfectly works with a white theme and landscape.
It will work better with cutouts on a real device.
And we fixed the navigation bar color in another branch.