Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/app update #79

Merged
merged 14 commits into from
Nov 2, 2023

Conversation

PavloNetrebchuk
Copy link
Contributor

@PavloNetrebchuk PavloNetrebchuk commented Oct 26, 2023

Update required:

  • If a user is not logged in.
    Screenshot 2023-10-26 at 16 29 26

  • If a user is logged in.
    Screenshot 2023-10-26 at 16 35 18

  • Account settings. The item labeled as "version" can be clicked. Navigation buttons are inactive.
    Screenshot 2023-10-26 at 16 36 32

Update recommended:

  • The discovery screen displays a large dialog.
    Screenshot 2023-10-27 at 13 26 27

  • Users will see small clickable dialog boxes on the discovery and dashboard screens.
    Screenshot 2023-10-26 at 16 42 47
    Screenshot 2023-10-26 at 16 42 33

  • The button on the profile screen is clickable
    Screenshot 2023-10-26 at 16 45 21

Up to date:
Screenshot 2023-10-26 at 16 49 44

Also, it perfectly works with a white theme and landscape.
Screenshot 2023-10-27 at 13 25 39
Screenshot 2023-10-26 at 17 00 43
Screenshot 2023-10-26 at 17 01 27
Screenshot 2023-10-26 at 17 01 39

It will work better with cutouts on a real device.
Screenshot 2023-10-26 at 16 53 18
And we fixed the navigation bar color in another branch.
Screenshot 2023-10-26 at 16 54 40

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 26, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 26, 2023

Thanks for the pull request, @PavloNetrebchuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@sdaitzman
Copy link

sdaitzman commented Oct 27, 2023

Thanks @PavloNetrebchuk! The feature looks good to me.

I did notice some variation in the shades of blue used for accent color and accent text color in dark mode. It might be a compression artifact with the screenshot, can you confirm if they match the correct values in the build?

image

@PavloNetrebchuk
Copy link
Contributor Author

Hello @sdaitzman
I agree with you. I have already made the necessary changes.
Screenshot 2023-10-27 at 19 32 38

# Conflicts:
#	app/src/main/java/org/openedx/app/AppRouter.kt
#	app/src/main/java/org/openedx/app/di/AppModule.kt
#	app/src/main/java/org/openedx/app/di/ScreenModule.kt
#	auth/src/main/java/org/openedx/auth/presentation/signin/SignInFragment.kt
@sdaitzman
Copy link

Thank you! That looks right to me

@volodymyr-chekyrta volodymyr-chekyrta linked an issue Nov 2, 2023 that may be closed by this pull request
@volodymyr-chekyrta volodymyr-chekyrta merged commit 166a1ee into openedx:develop Nov 2, 2023
1 check passed
@openedx-webhooks
Copy link

@PavloNetrebchuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta volodymyr-chekyrta deleted the feature/app_update branch November 2, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

App Update messaging [Android]
4 participants