Skip to content

Commit

Permalink
fix: address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@IvanStepanok
IvanStepanok committed Nov 4, 2024
1 parent 540c918 commit 16fd879
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 34 deletions.
35 changes: 4 additions & 31 deletions Core/Core.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@
BAFB99922B14E23D007D09F9 /* AppleSignInConfig.swift in Sources */ = {isa = PBXBuildFile; fileRef = BAFB99912B14E23D007D09F9 /* AppleSignInConfig.swift */; };
C8C446EF233F81B9FABB77D2 /* Pods_App_Core.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 349B90CD6579F7B8D257E515 /* Pods_App_Core.framework */; };
CE54C2D22CC80D8500E529F9 /* DownloadManagerTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE54C2D12CC80D8500E529F9 /* DownloadManagerTests.swift */; };
CE953A3B2CD0DA940023D667 /* CoreMock.generated.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE953A3A2CD0DA940023D667 /* CoreMock.generated.swift */; };
CE57127C2CD109DB00D4AB17 /* OEXFoundation in Frameworks */ = {isa = PBXBuildFile; productRef = CE57127B2CD109DB00D4AB17 /* OEXFoundation */; };
CE7CAF392CC1561E00E0AC9D /* OEXFoundation in Frameworks */ = {isa = PBXBuildFile; productRef = CE7CAF382CC1561E00E0AC9D /* OEXFoundation */; };
CE953A3B2CD0DA940023D667 /* CoreMock.generated.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE953A3A2CD0DA940023D667 /* CoreMock.generated.swift */; };
CFC84952299F8B890055E497 /* Debounce.swift in Sources */ = {isa = PBXBuildFile; fileRef = CFC84951299F8B890055E497 /* Debounce.swift */; };
DBF6F2412B014ADA0098414B /* FirebaseConfig.swift in Sources */ = {isa = PBXBuildFile; fileRef = DBF6F2402B014ADA0098414B /* FirebaseConfig.swift */; };
DBF6F2462B01DAFE0098414B /* AgreementConfig.swift in Sources */ = {isa = PBXBuildFile; fileRef = DBF6F2452B01DAFE0098414B /* AgreementConfig.swift */; };
Expand Down Expand Up @@ -342,7 +342,6 @@
A595689A2B6173DF00ED4F90 /* BranchConfig.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BranchConfig.swift; sourceTree = "<group>"; };
A5F4E7B42B61544A00ACD166 /* BrazeConfig.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = BrazeConfig.swift; sourceTree = "<group>"; };
B2556B4A2D4F84F402A7A7D9 /* Pods-CoreTests.releaseprod.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-CoreTests.releaseprod.xcconfig"; path = "Target Support Files/Pods-CoreTests/Pods-CoreTests.releaseprod.xcconfig"; sourceTree = "<group>"; };
BA30427D2B20B299009B64B7 /* SocialAuthError.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = SocialAuthError.swift; sourceTree = "<group>"; };
BA4AFB412B5A7A0900A21367 /* VideoDownloadQualityView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoDownloadQualityView.swift; sourceTree = "<group>"; };
BA4AFB432B6A5AF100A21367 /* CheckBoxView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CheckBoxView.swift; sourceTree = "<group>"; };
BA593F1B2AF8E498009ADB51 /* ScrollSlidingTabBar.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ScrollSlidingTabBar.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -972,7 +971,7 @@
mainGroup = 0770DDFE28D07831006D8A5D;
packageReferences = (
02AA27922C2C1B61006F5B6A /* XCRemoteSwiftPackageReference "ZipArchive" */,
CE5712772CD1074D00D4AB17 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */,
CE924BE42CD8F8E4000137CA /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */,
);
productRefGroup = 0770DE0928D07831006D8A5D /* Products */;
projectDirPath = "";
Expand Down Expand Up @@ -2289,36 +2288,12 @@
minimumVersion = 2.5.5;
};
};
142EDD6A2B831D1400F9F320 /* XCRemoteSwiftPackageReference "ios-branch-sdk-spm" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/BranchMetrics/ios-branch-sdk-spm";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 3.6.3;
};
};
BA8FA65E2AD574D700EA029A /* XCRemoteSwiftPackageReference "GoogleSignIn-iOS" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/google/GoogleSignIn-iOS";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 8.0.0;
};
};
BA8FA6712AD6ABA300EA029A /* XCRemoteSwiftPackageReference "facebook-ios-sdk" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/facebook/facebook-ios-sdk";
requirement = {
kind = upToNextMajorVersion;
minimumVersion = 17.4.0;
};
};
CEE886B12CB928010092A175 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */ = {
CE924BE42CD8F8E4000137CA /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/openedx/openedx-app-foundation-ios/";
requirement = {
kind = exactVersion;
version = 0.1.0;
version = 1.0.0;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand All @@ -2331,12 +2306,10 @@
};
CE57127B2CD109DB00D4AB17 /* OEXFoundation */ = {
isa = XCSwiftPackageProductDependency;
package = CE5712772CD1074D00D4AB17 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */;
productName = OEXFoundation;
};
CE7CAF382CC1561E00E0AC9D /* OEXFoundation */ = {
isa = XCSwiftPackageProductDependency;
package = CEB1E25C2CC1439700921517 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */;
productName = OEXFoundation;
};
/* End XCSwiftPackageProductDependency section */
Expand Down
22 changes: 19 additions & 3 deletions OpenEdX.xcodeproj/project.pbxproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@
A59568952B61630500ED4F90 /* DeepLinkManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = A59568942B61630500ED4F90 /* DeepLinkManager.swift */; };
A59568972B61653700ED4F90 /* DeepLink.swift in Sources */ = {isa = PBXBuildFile; fileRef = A59568962B61653700ED4F90 /* DeepLink.swift */; };
A59568992B616D9400ED4F90 /* PushLink.swift in Sources */ = {isa = PBXBuildFile; fileRef = A59568982B616D9400ED4F90 /* PushLink.swift */; };
BA3042792B1F7147009B64B7 /* MSAL in Frameworks */ = {isa = PBXBuildFile; productRef = BA3042782B1F7147009B64B7 /* MSAL */; };
BA7468762B96201D00793145 /* DeepLinkRouter.swift in Sources */ = {isa = PBXBuildFile; fileRef = BA7468752B96201D00793145 /* DeepLinkRouter.swift */; };
CE3BD14E2CBEB0DA0026F4E3 /* PluginManager.swift in Sources */ = {isa = PBXBuildFile; fileRef = CE3BD14D2CBEB0DA0026F4E3 /* PluginManager.swift */; };
CE5712792CD1099B00D4AB17 /* OEXFirebaseAnalytics in Frameworks */ = {isa = PBXBuildFile; productRef = CE5712782CD1099B00D4AB17 /* OEXFirebaseAnalytics */; };
CE57127A2CD109A800D4AB17 /* OEXFoundation in Embed Frameworks */ = {isa = PBXBuildFile; productRef = CE9C07D72CD104E5009C44D1 /* OEXFoundation */; settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; };
CE924BE72CD8FAB3000137CA /* FirebaseMessaging in Frameworks */ = {isa = PBXBuildFile; productRef = CE924BE62CD8FAB3000137CA /* FirebaseMessaging */; };
CE9C07D82CD104E5009C44D1 /* OEXFoundation in Frameworks */ = {isa = PBXBuildFile; productRef = CE9C07D72CD104E5009C44D1 /* OEXFoundation */; };
E0D6E6A32B1626B10089F9C9 /* Theme.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = E0D6E6A22B1626B10089F9C9 /* Theme.framework */; };
E0D6E6A42B1626D60089F9C9 /* Theme.framework in Embed Frameworks */ = {isa = PBXBuildFile; fileRef = E0D6E6A22B1626B10089F9C9 /* Theme.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
Expand Down Expand Up @@ -165,6 +165,7 @@
025DE1A428DB4DAE0053E0F4 /* Profile.framework in Frameworks */,
0770DE4B28D0A462006D8A5D /* Authorization.framework in Frameworks */,
072787B128D34D83002E9142 /* Discovery.framework in Frameworks */,
CE924BE72CD8FAB3000137CA /* FirebaseMessaging in Frameworks */,
0218196428F734FA00202564 /* Discussion.framework in Frameworks */,
0219C67728F4347600D64452 /* Course.framework in Frameworks */,
027DB33028D8A063002B6862 /* Dashboard.framework in Frameworks */,
Expand Down Expand Up @@ -398,6 +399,7 @@
packageProductDependencies = (
CE9C07D72CD104E5009C44D1 /* OEXFoundation */,
CE5712782CD1099B00D4AB17 /* OEXFirebaseAnalytics */,
CE924BE62CD8FAB3000137CA /* FirebaseMessaging */,
);
productName = OpenEdX;
productReference = 07D5DA3128D075AA00752FD9 /* OpenEdX.app */;
Expand Down Expand Up @@ -431,6 +433,7 @@
packageReferences = (
CE9C07D62CD104E5009C44D1 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */,
CE9C07D92CD10581009C44D1 /* XCRemoteSwiftPackageReference "openedx-app-firebase-analytics-ios" */,
CE924BE52CD8FAB3000137CA /* XCRemoteSwiftPackageReference "firebase-ios-sdk" */,
);
productRefGroup = 07D5DA3228D075AA00752FD9 /* Products */;
projectDirPath = "";
Expand Down Expand Up @@ -1221,6 +1224,14 @@
/* End XCConfigurationList section */

/* Begin XCRemoteSwiftPackageReference section */
CE924BE52CD8FAB3000137CA /* XCRemoteSwiftPackageReference "firebase-ios-sdk" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/firebase/firebase-ios-sdk.git";
requirement = {
kind = exactVersion;
version = 11.3.0;
};
};
CE9C07D62CD104E5009C44D1 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/openedx/openedx-app-foundation-ios/";
Expand All @@ -1231,10 +1242,10 @@
};
CE9C07D92CD10581009C44D1 /* XCRemoteSwiftPackageReference "openedx-app-firebase-analytics-ios" */ = {
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/raccoongang/openedx-app-firebase-analytics-ios";
repositoryURL = "https://github.com/openedx/openedx-app-firebase-analytics-ios";
requirement = {
kind = exactVersion;
version = 0.1.0;
version = 1.0.0;
};
};
/* End XCRemoteSwiftPackageReference section */
Expand All @@ -1245,6 +1256,11 @@
package = CE9C07D92CD10581009C44D1 /* XCRemoteSwiftPackageReference "openedx-app-firebase-analytics-ios" */;
productName = OEXFirebaseAnalytics;
};
CE924BE62CD8FAB3000137CA /* FirebaseMessaging */ = {
isa = XCSwiftPackageProductDependency;
package = CE924BE52CD8FAB3000137CA /* XCRemoteSwiftPackageReference "firebase-ios-sdk" */;
productName = FirebaseMessaging;
};
CE9C07D72CD104E5009C44D1 /* OEXFoundation */ = {
isa = XCSwiftPackageProductDependency;
package = CE9C07D62CD104E5009C44D1 /* XCRemoteSwiftPackageReference "openedx-app-foundation-ios" */;
Expand Down

0 comments on commit 16fd879

Please sign in to comment.