fix: address feedback

openedx · Nov 20, 2024 · 723b45a · 723b45a
1 parent e38a7de
commit 723b45a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/Course/Course/Presentation/Unit/CourseUnitView.swift b/Course/Course/Presentation/Unit/CourseUnitView.swift
@@ -102,7 +102,7 @@ public struct CourseUnitView: View {
                                           textColor: Theme.Colors.white)
                         .transition(.move(edge: .bottom))
                         .onAppear {
-                            DispatchQueue.main.asyncAfter(deadline: .now() + Theme.Timeout.snackbarMessageLongTimeout) {
+                            doAfter(Theme.Timeout.snackbarMessageLongTimeout) {
                                 alertMessage = nil
                                 showAlert = false
                             }

diff --git a/OpenEdX.xcodeproj/project.pbxproj b/OpenEdX.xcodeproj/project.pbxproj
@@ -907,7 +907,7 @@
 				CODE_SIGN_ENTITLEMENTS = OpenEdX/OpenEdX.entitlements;
 				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 1;
-				DEVELOPMENT_TEAM = L8PG7LC3Y3;
+				DEVELOPMENT_TEAM = "";
 				FULLSTORY_ENABLED = NO;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_FILE = OpenEdX/Info.plist;
@@ -999,7 +999,7 @@
 				CODE_SIGN_ENTITLEMENTS = OpenEdX/OpenEdX.entitlements;
 				CODE_SIGN_STYLE = Automatic;
 				CURRENT_PROJECT_VERSION = 1;
-				DEVELOPMENT_TEAM = L8PG7LC3Y3;
+				DEVELOPMENT_TEAM = "";
 				FULLSTORY_ENABLED = NO;
 				GENERATE_INFOPLIST_FILE = YES;
 				INFOPLIST_FILE = OpenEdX/Info.plist;

diff --git a/Profile/Profile/Presentation/Settings/SettingsViewModel.swift b/Profile/Profile/Presentation/Settings/SettingsViewModel.swift
@@ -135,11 +135,9 @@ public final class SettingsViewModel: ObservableObject {
         return emailURL
     }
 
-    func update(downloadQuality: DownloadQuality) {
+    func update(downloadQuality: DownloadQuality) async {
         self.userSettings.downloadQuality = downloadQuality
-        Task {
-            await interactor.saveSettings(userSettings)
-        }
+        await interactor.saveSettings(userSettings)
     }
 
     @MainActor

diff --git a/Profile/Profile/Presentation/Settings/VideoSettingsView.swift b/Profile/Profile/Presentation/Settings/VideoSettingsView.swift
@@ -90,7 +90,11 @@ public struct VideoSettingsView: View {
                                 Button {
                                     viewModel.router.showVideoDownloadQualityView(
                                         downloadQuality: viewModel.userSettings.downloadQuality,
-                                        didSelect: viewModel.update(downloadQuality:),
+                                        didSelect: { quality in
+                                            Task {
+                                                await viewModel.update(downloadQuality: quality)
+                                            }
+                                        },
                                         analytics: viewModel.coreAnalytics
                                     )
                                 } label: {