refactor: address review feedback

openedx · Dec 18, 2023 · 89d5559 · 89d5559
1 parent 9289ff2
commit 89d5559
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/Authorization/Authorization/Presentation/Login/SignInViewModel.swift b/Authorization/Authorization/Presentation/Login/SignInViewModel.swift
@@ -19,7 +19,7 @@ public class SignInViewModel: ObservableObject {
     @Published private(set) var isShowProgress = false
     @Published private(set) var showError: Bool = false
     @Published private(set) var showAlert: Bool = false
-    public var sourceScreen: LogistrationSourceScreen
+    let sourceScreen: LogistrationSourceScreen
 
     var errorMessage: String? {
         didSet {

diff --git a/Authorization/Authorization/Presentation/Registration/SignUpViewModel.swift b/Authorization/Authorization/Presentation/Registration/SignUpViewModel.swift
@@ -19,7 +19,7 @@ public class SignUpViewModel: ObservableObject {
     @Published var scrollTo: Int?
     @Published var showError: Bool = false
     @Published var thirdPartyAuthSuccess: Bool = false
-    public var sourceScreen: LogistrationSourceScreen
+    let sourceScreen: LogistrationSourceScreen
 
     var errorMessage: String? {
         didSet {

diff --git a/Course/Course/Presentation/Details/CourseDetailsViewModel.swift b/Course/Course/Presentation/Details/CourseDetailsViewModel.swift
@@ -8,7 +8,6 @@
 import Foundation
 import Core
 import SwiftUI
-import Swinject
 
 public enum CourseState {
     case enrollOpen

diff --git a/Discovery/Discovery/Presentation/DiscoveryViewModel.swift b/Discovery/Discovery/Presentation/DiscoveryViewModel.swift
@@ -8,8 +8,6 @@
 import Combine
 import Core
 import SwiftUI
-import Swinject
-import Authorization
 
 public class DiscoveryViewModel: ObservableObject {
 

diff --git a/OpenEdX/RouteController.swift b/OpenEdX/RouteController.swift
@@ -51,8 +51,10 @@ class RouteController: UIViewController {
             let controller = UIHostingController(
                 rootView: SignInView(
                     viewModel:
-                        diContainer.resolve(SignInViewModel.self,
-                                            argument: LogistrationSourceScreen.default)!
+                        diContainer.resolve(
+                            SignInViewModel.self,
+                            argument: LogistrationSourceScreen.default
+                        )!
                 )
             )
             navigation.viewControllers = [controller]