Skip to content

Commit

Permalink
october bugfixes (#100)
Browse files Browse the repository at this point in the history
* october bugfixes

Change some icons to help adjust color themes (DeleteAccountView, Send button on the keyboard, etc.)
Fix CSSInjector style by adding 100% width. Need for normal work at Handouts view.
Add new logic for icons viewing in CourseVerticalView.
Fix a bug where the discussion page does not appear in case there is only one on the page.
Fix a bug with text trimming on ParentCommentView.
Change button design on PostsView by Design code.
Fix the issue with the English localization on DeleteAccountView.
Fix error handling at DeleteAccountViewModel.

* update xcode version for unit tests

* Downgrade xcode version for unit tests

* Update unit_tests.yml

* Update Fastfile

* Update unit_tests.yml

* code style improvements
  • Loading branch information
IvanStepanok authored Oct 4, 2023
1 parent d029734 commit b76d824
Show file tree
Hide file tree
Showing 28 changed files with 172 additions and 84 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ jobs:
run:
source ci_scripts/ci_prepare_env.sh && setup_github_actions_environment

- run: |
xcversion installed
- name: SwiftLint
run:
bundle exec fastlane linting
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "Group 62.svg",
"filename" : "send.svg",
"idiom" : "universal"
},
{
Expand All @@ -11,7 +11,7 @@
"value" : "dark"
}
],
"filename" : "Group 62-2.svg",
"filename" : "send 1.svg",
"idiom" : "universal"
}
],
Expand Down
12 changes: 0 additions & 12 deletions Core/Core/Assets.xcassets/Discussions/send.imageset/Group 62-2.svg

This file was deleted.

12 changes: 0 additions & 12 deletions Core/Core/Assets.xcassets/Discussions/send.imageset/Group 62.svg

This file was deleted.

11 changes: 11 additions & 0 deletions Core/Core/Assets.xcassets/Discussions/send.imageset/send 1.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions Core/Core/Assets.xcassets/Discussions/send.imageset/send.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"images" : [
{
"filename" : "Group-2.svg",
"filename" : "delete_bg_light.svg",
"idiom" : "universal"
},
{
Expand All @@ -11,7 +11,7 @@
"value" : "dark"
}
],
"filename" : "Group.svg",
"filename" : "bg_delete 1.svg",
"idiom" : "universal"
}
],
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

This file was deleted.

13 changes: 0 additions & 13 deletions Core/Core/Assets.xcassets/Profile/deleteAccount.imageset/Group.svg

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"images" : [
{
"filename" : "delete_char.svg",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
},
"properties" : {
"template-rendering-intent" : "template"
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"images" : [
{
"filename" : "delete_eyes.svg",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
Loading

0 comments on commit b76d824

Please sign in to comment.