Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: course dates #137

Merged
merged 11 commits into from
Nov 2, 2023

Conversation

mumer92
Copy link
Contributor

@mumer92 mumer92 commented Oct 26, 2023

This PR adds support for Course Dates. #85

This is preliminary PR with the Course Dates feature. Designs are TBD.

Screenshots:
Screenshot 2023-10-31 at 11 56 18 PM
Screenshot 2023-10-31 at 11 56 35 PM

Note
Not included in this ticket:

  • Calendar integration
  • PLS (shift due dates)
  • Linking of items on the dates page to specific assessments within the app

@mumer92 mumer92 changed the title feat: Course Dates Add Course Dates Oct 26, 2023
@mumer92 mumer92 changed the title Add Course Dates feat: Course Dates Oct 31, 2023
@mumer92 mumer92 changed the title feat: Course Dates feat: course dates Nov 1, 2023
@mumer92
Copy link
Contributor Author

mumer92 commented Nov 1, 2023

@volodymyr-chekyrta i have updated the PR, added translations and added few files to .gitignore to ignore the files that were previously checked into the repo.

@volodymyr-chekyrta
Copy link
Contributor

@mumer92 Thank you! 🙌

Would you mind to check the CourseDateBlock file?
I noticed that var blockTitle: String appears to still be hardcoded.

Could you also check those files? I'm uncertain, but it seems to me that they may still be present in the project:
Core/Core.xcodeproj.xcworkspace/xcuserdata/m.umer.xcuserdatad Course/Course.xcodeproj/project.xcworkspace/xcuserdata/m.umer.xcuserdatad Discovery/Discovery.xcodeproj/project.xcworkspace/xcuserdata/m.umer.xcuserdatad

@volodymyr-chekyrta volodymyr-chekyrta merged commit 5bd9203 into openedx:develop Nov 2, 2023
1 check passed
@eyatsenkoperpetio
Copy link
Contributor

Hi, small problem @mumer92
Screenshot 2023-11-03 at 15 48 59

@mumer92
Copy link
Contributor Author

mumer92 commented Nov 6, 2023

@eyatsenkoperpetio i have created #149

@mumer92 mumer92 requested a review from saeedbashir November 6, 2023 11:40
@touchapp
Copy link

touchapp commented Nov 7, 2023

@marcotuts can we have Sam take a look at this? I think it needs some design love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants