-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added login and register capability in discovery for pre login exploration #202
Merged
volodymyr-chekyrta
merged 13 commits into
openedx:develop
from
saeedbashir:saeed/pre_login_exploration_discovery
Dec 19, 2023
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b7ab020
feat: added login and register capebility in discovery for pre login …
saeedbashir 49a8f9f
refactor: address review feedback
saeedbashir 31d997f
fix: fix broken tests
saeedbashir bf42b25
fix: linking authorization framework with discovery framework
saeedbashir 83d62bd
refactor: address review feedback
saeedbashir e30d54a
refactor: address review feedback
saeedbashir 9289ff2
fix: fix broken tests after changes
saeedbashir 89d5559
refactor: address review feedback
saeedbashir 89f6c4b
refactor: changing LogistrationBottomView style from model to closure…
saeedbashir a890722
Merge branch 'develop' into saeed/pre_login_exploration_discovery
saeedbashir fb856ac
refactor: address review feedback
saeedbashir d223fab
refactor: decouple Authorization and Discovery module, remove unused …
saeedbashir 0f6a5cb
refactor: removing unused imports
saeedbashir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In various locations, we utilize
LogistrationSourceScreen.startup
, while here it employs.startup
. It is necessary to ensure uniformity.