Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL localization for assets and strings #441

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

RawanMatar89
Copy link
Contributor

Describtion:

  1. changed "direction" attribute for "arrowRight16" image in "Core/Assets" from attribute inspector.
  2. localize "chevron.right" system image that used in:
    CourseButton
    HandoutsView
    CourseStructureView
    CourseVerticalView
    CourseDatesView
    DiscussionTopicsView
    ProfileSupportInfoView
    SettingsView
    using "flipsForRightToLeftLayoutDirection" method
  3. localize "CompletionStatus" enum string by adding localized var that returns a localized string.

Screenshots:

Before After
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 50 23 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 55 57
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 50 43 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 56 10
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 52 02 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 57 15
Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 52 25 Simulator Screenshot - iPhone 15 Pro Max - 2024-05-23 at 09 56 18

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 23, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 23, 2024

Thanks for the pull request, @RawanMatar89!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@RawanMatar89 RawanMatar89 force-pushed the rtl_localizations branch 3 times, most recently from 47fa067 to 7374fb2 Compare May 23, 2024 08:43
@RawanMatar89 RawanMatar89 marked this pull request as draft May 23, 2024 10:15
@OmarIthawi
Copy link
Member

OmarIthawi commented May 30, 2024

@RawanMatar89 please check the test failures https://github.com/openedx/openedx-app-ios/actions/runs/9204972524/job/25319630671?pr=441


[Course] Compiling HandoutsView.swift
Error: value of type 'some View' has no member 'resizable'
                    .resizable()
                     ^~~~~~~~~
[Course] Compiling DiscussionView.swift
[Course] Compiling Strings.swift
[Course] Compiling CalendarSyncProgressView.swift
[Course] Compiling DownloadsView.swift
[Course] Compiling DatesSuccessView.swift
[Course] Compiling CourseHeaderView.swift
[Course] Compiling CourseDatesView.swift
Error: static method 'buildExpression' requires that 'Spacer' conform to 'AccessibilityRotorContent'
                        Spacer()
                        ^
Error: value of type 'some View' has no member 'resizable'
                            .resizable()
                             ^~~~~~~~~
Error: cannot infer contextual base in reference to member 'iconOnly'
                            .labelStyle(.iconOnly)
                                        ~^~~~~~~~
Warning: The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 11.0, but the range of supported deployment target versions is 12.0 to 17.4.99. (in target 'SwiftLint' from project 'Pods')

@OmarIthawi
Copy link
Member

@RawanMatar89 please rebase over openedx:develop, resolve conflicts and fix failing tests mentioned in #441 (comment)

Comment on lines +290 to +291
.flipsForRightToLeftLayoutDirection(true)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the extra line here.

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RawanMatar89. The pull request looks good to me (as a non iOS engineer).

Please mark it as "Ready for review".

@volodymyr-chekyrta kindly triage this PR and let us know if you have any quesations.

@RawanMatar89 RawanMatar89 marked this pull request as ready for review July 15, 2024 13:36
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta volodymyr-chekyrta merged commit 73e6175 into openedx:develop Jul 25, 2024
3 checks passed
@openedx-webhooks
Copy link

@RawanMatar89 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@volodymyr-chekyrta
Copy link
Contributor

@RawanMatar89, thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants