Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: first batch of fix PRs to synchronise with upstream #526

Merged
merged 10 commits into from
Oct 8, 2024

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Oct 7, 2024

This batch contains next fixes:

  1. Fix for delete remaining tmp files when cancel video download - fix: fixes for downloading edx/edx-mobile-marketplace-ios#23
  2. When open Course "Home" tab, a list of course sections is shown but over time, the height of the cells increases -
    fix: [iOS] On Course "Home" tab the row height edx/edx-mobile-marketplace-ios#24
  3. UI improvement for Primary Card Landscape - feat: Landscape mode Improvement edx/edx-mobile-marketplace-ios#25
  4. Don’t show the error snack bar on the failure of API /api/course_experience/v1/course_deadlines_info/ - chore: remove snack bar error for course dates info API on course home edx/edx-mobile-marketplace-ios#27
  5. Course Level Error Handling for Empty States - feat: Course Level Error Handling for Empty States edx/edx-mobile-marketplace-ios#28

@rnr rnr requested a review from volodymyr-chekyrta October 7, 2024 11:48
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta volodymyr-chekyrta merged commit 004666e into openedx:develop Oct 8, 2024
6 checks passed
@rnr rnr deleted the portion-1-sync-to-upstream branch November 22, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants