Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Part 5 sync to upstream #542

Merged
merged 9 commits into from
Nov 18, 2024
Merged

fix: Part 5 sync to upstream #542

merged 9 commits into from
Nov 18, 2024

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Nov 11, 2024

This sync PR contains next fixes:

  1. Add eye icon for password field feat: eye icon for password field edx/edx-mobile-marketplace-ios#42
Screenshot 2024-11-11 at 11 29 55
  1. Clear cookies by logout to fix Register experience fix: clear cookies by logout edx/edx-mobile-marketplace-ios#44
  2. UI fix: reduce grid spacing style: reduce grid spacing edx/edx-mobile-marketplace-ios#47
Screenshot 2024-11-11 at 11 26 34
  1. UI fix for Alert’s Title truncation chore: Fix outdated course dates alert title truncation issue edx/edx-mobile-marketplace-ios#53
Screenshot 2024-11-11 at 11 27 28
  1. Videos Tab: Show downloading video size in Mb or Gb chore: size in GB or MB edx/edx-mobile-marketplace-ios#57
  2. Remove urls from headings of End User license agreements fix: Remove urls from headings of End User lisence agreements edx/edx-mobile-marketplace-ios#65

volodymyr-chekyrta
volodymyr-chekyrta approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta volodymyr-chekyrta merged commit f209262 into openedx:develop Nov 18, 2024
7 checks passed
@rnr rnr deleted the part-5-sync-to-upstream branch November 22, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyr-chekyrta volodymyr-chekyrta volodymyr-chekyrta approved these changes

@IvanStepanok IvanStepanok Awaiting requested review from IvanStepanok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rnr @volodymyr-chekyrta @shafqat-muneer