Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quick fix whitelabel script error #546

Merged

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Dec 5, 2024

Fix whitelabel script execution after commenting out Fullstory function - added pass into empty if
Without this script produces error:

  File ".../config_script/whitelabel.py", line 572
    else:
    ^
IndentationError: expected an indented block after 'if' statement on line 569
... % python3 config_script/whitelabel.py --config-file=../edx-mobile-config/openEdXAssets/whitelabel.yaml

Also updated regex to find the development team in the project file, as it could be empty

@rnr rnr marked this pull request as draft December 5, 2024 12:58
@rnr rnr marked this pull request as ready for review December 5, 2024 13:22
@volodymyr-chekyrta volodymyr-chekyrta merged commit b3e6184 into openedx:develop Dec 5, 2024
7 checks passed
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@55f601c). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             develop   #546   +/-   ##
========================================
  Coverage           ?      0           
========================================
  Files              ?      0           
  Lines              ?      0           
  Branches           ?      0           
========================================
  Hits               ?      0           
  Misses             ?      0           
  Partials           ?      0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnr rnr deleted the quickfix/whitelabel-script-error branch December 5, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants