-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vector with defaults #93
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dc1be79
feat: add vector with defaults
Ian2012 28dd360
docs: add example of a ClickHouse sink
Ian2012 b14aad3
docs: add example of a ClickHouse sink
Ian2012 55d98f5
fix: update default values
Ian2012 dd6af15
docs: add example of a ClickHouse sink
Ian2012 c767ef3
fix: avoid adding an extra line to log files
Ian2012 7ddd527
chore: bumping the HArmony chart version and updating lock file
jfavellar90 3728c72
chore: bump version to 0.9.0
Ian2012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this going to work with the existing Aspects vector settings? Are the two going to be exclusive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both need to be exclusive, for resource consumption and pipeline tracking. However, another filter and a sink can be added to filter specifics of any namespace.
However, keep in mind that Ralph is the recommended pipeline to use.
I can leave examples for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, when this merges you should also update these docs:
https://docs.openedx.org/projects/openedx-aspects/en/latest/technical_documentation/how-tos/production_configuration.html#vector
https://docs.openedx.org/projects/openedx-aspects/en/latest/technical_documentation/quickstarts/vector.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've implemented a ClickHouse filter and sink example. Assuming there are multiple OpenedX installations in the same cluster, a filter, a transformer, and a sink must be implemented per namespace.
Basically what we do is:
xapi_tracking
logs. (transformer)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ian2012 Can you please give an example for multiple instance per cluster configuration setup in the https://github.com/openedx/openedx-k8s-harmony/blob/main/values-example.yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the values-example.yaml with the elements for one installation filtered by namespace. It just needs to be replicated for every openedx namespace with Aspects installed.