-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent #NaN color picker values #2734
fix: prevent #NaN color picker values #2734
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
d677d80
to
d194a3d
Compare
Hello, @brian-smith-tcril! I have looked at your solution for the #2524 and we with our team and @adamstankiewicz decided to choose your PR and close our other PR for colorpicker. |
7841218
to
3e48a61
Compare
ca8e5fd
to
89e10bf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2734 +/- ##
==========================================
+ Coverage 92.83% 92.86% +0.03%
==========================================
Files 235 235
Lines 4240 4261 +21
Branches 1029 1030 +1
==========================================
+ Hits 3936 3957 +21
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
89e10bf
to
b14e676
Compare
@monteri this is out of draft and ready for review now! |
🎉 This PR is included in version 21.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 22.0.0-alpha.24 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fixes #2524
This updates the picker to have a separate
colorToDisplay
used by the textbox, andhexColorString
used by the internal picker. This allows us to have invalid color values (which happens with any string that isn't 3 or 6 characters) without blocking user input.This way users can still:
Deploy Preview
https://deploy-preview-2734--paragon-openedx.netlify.app/components/colorpicker/
Merge Checklist
example
app?wittjeff
andadamstankiewicz
as reviewers on this PR.Post-merge Checklist