-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated Elevation and Responsive docs #3335
base: release-23.x
Are you sure you want to change the base?
docs: updated Elevation and Responsive docs #3335
Conversation
Thanks for the pull request, @PKulkoRaccoonGang! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2563e39
to
86c3bac
Compare
@@ -99,6 +124,57 @@ function Responsive({ pageContext }) { | |||
<CodeBlock className="language-scss"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On this page I am not sure if it is worth deleting information that relates to SCSS variables. Any thoughts?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #3335 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 229 229
Lines 3836 3836
Branches 916 920 +4
=======================================
Hits 3599 3599
Misses 230 230
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Description
On the alpha version of the Paragon documentation site, on the Elevation and Responsive pages, there is not enough complete information about the innovations that have appeared in Paragon (CSS variables).
Merge Checklist
example
app?Post-merge Checklist