-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: deprecate Truncate
component
#3336
feat!: deprecate Truncate
component
#3336
Conversation
✅ Deploy Preview for paragon-openedx ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha #3336 +/- ##
==========================================
- Coverage 93.82% 93.75% -0.07%
==========================================
Files 229 230 +1
Lines 3836 3862 +26
Branches 916 899 -17
==========================================
+ Hits 3599 3621 +22
- Misses 230 237 +7
+ Partials 7 4 -3 ☔ View full report in Codecov by Sentry. |
@@ -66,4 +66,9 @@ Truncate.defaultProps = { | |||
onTruncate: undefined, | |||
}; | |||
|
|||
function Truncate() { | |||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[consideration] I wonder if it'd be worth having something like a console.log
or similar here to give some output when this no-op component is used, e.g.
function Truncate() {
useEffect(() => {
console.log('Please use Truncate.Deprecated until a replacement is created');
}, []);
return null;
}
3678ea4
to
f781370
Compare
🎉 This PR is included in version 23.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 23.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
See #3311 (comment)
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
example
app?Post-merge Checklist