chore: quality fixes

platform_plugin_aspects/apps.py

@@ -44,11 +44,9 @@ class PlatformPluginAspectsConfig(AppConfig):
     def ready(self):
         """Load modules of Aspects."""
         super().ready()
-        from platform_plugin_aspects.extensions import filters  # pylint: disable=unused-import, import-outside-toplevel
-
         from platform_plugin_aspects import (  # pylint: disable=import-outside-toplevel, unused-import
             signals,
             sinks,
             tasks,
         )
-
+        from platform_plugin_aspects.extensions import filters  # pylint: disable=unused-import, import-outside-toplevel

platform_plugin_aspects/utils.py

@@ -4,6 +4,7 @@
 
 import logging
 import os
+from importlib import import_module
 
 from crum import get_current_user
 from django.conf import settings
@@ -116,39 +117,31 @@ def generate_guest_token(user, course, dashboard_uuid, filters):
         logger.error(exc)
         return None, exc
 
-"""Utility functions for event_sink_clickhouse."""
-import logging
-from importlib import import_module
-
-from django.conf import settings
-
-log = logging.getLogger(__name__)
-
 
 def get_model(model_setting):
     """Load a model from a setting."""
     MODEL_CONFIG = getattr(settings, "EVENT_SINK_CLICKHOUSE_MODEL_CONFIG", {})
 
     model_config = MODEL_CONFIG.get(model_setting)
     if not model_config:
-        log.error("Unable to find model config for %s", model_setting)
+        logger.error("Unable to find model config for %s", model_setting)
         return None
 
     module = model_config.get("module")
     if not module:
-        log.error("Module was not specified in %s", model_setting)
+        logger.error("Module was not specified in %s", model_setting)
         return None
 
     model_name = model_config.get("model")
     if not model_name:
-        log.error("Model was not specified in %s", model_setting)
+        logger.error("Model was not specified in %s", model_setting)
         return None
 
     try:
         model = getattr(import_module(module), model_name)
         return model
     except (ImportError, AttributeError, ModuleNotFoundError):
-        log.error("Unable to load model %s.%s", module, model_name)
+        logger.error("Unable to load model %s.%s", module, model_name)
 
     return None
 

test_utils/test_utils.py

@@ -20,7 +20,7 @@ class TestUtils(unittest.TestCase):
         "EVENT_SINK_CLICKHOUSE_MODEL_CONFIG",
         {"my_model": {"module": "myapp.models", "model": "MyModel"}},
     )
-    @patch("platform_plugin_aspects.utils.log")
+    @patch("platform_plugin_aspects.utils.logger")
     def test_get_model_success(self, mock_log, mock_import_module):
         mock_model = Mock(__name__="MyModel")
         mock_import_module.return_value = Mock(MyModel=mock_model)