Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tag and taxonomy sink #82

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: add tag and taxonomy sink #82

merged 4 commits into from
Sep 4, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Aug 28, 2024

Description

This PR adds two new sinks for the Tag and Taxonomy models in openedx-learning.

Closes: openedx/tutor-contrib-aspects#926
Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 28, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 28, 2024

Thanks for the pull request, @Ian2012!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @bmtcril. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

github-actions bot commented Aug 28, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  platform_plugin_aspects
  __init__.py
  signals.py
  tasks.py
  utils.py
  platform_plugin_aspects/sinks
  __init__.py
  serializers.py 232, 257
  tag_sink.py
Project Total  

This report was generated by python-coverage-comment-action

fix: add lineage information for tag sink

chore: quality fixes

fix: serialize lineage data as json
fix: deleting course tags trigger update on courses
fix: dump tags ids

fix: add use set to store tags

chore: quality fixes
@Ian2012 Ian2012 changed the title feat: add tag and taxonomy dump feat: add tag and taxonomy sink Aug 30, 2024
@Ian2012 Ian2012 merged commit 684dc95 into main Sep 4, 2024
10 checks passed
@Ian2012 Ian2012 deleted the cag/tags branch September 4, 2024 12:51
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Adding tags to a course or course content doesn't trigger course sink
3 participants