Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import event-sink-clickhouse plugin #3

Merged
merged 13 commits into from
Mar 5, 2024
Merged

feat: import event-sink-clickhouse plugin #3

merged 13 commits into from
Mar 5, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Mar 1, 2024

Description

This PR imports the code from the openedx-event-sink-clickhouse repository.

@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this on my tutor dev stack by overriding this setting from Aspects, and testing to make sure events still appear in Superset as expected:
    OPENEDX_EXTRA_PIP_REQUIREMENTS:
    - git+https://github.com/openedx/platform-plugin-aspects.git@cag/import-sink#egg=platform_plugin_aspects
    - "edx-event-routing-backends==v8.1.1"
    
  • I skimmed through the code -- didn't read in detail since this is just a copy-over.
  • I checked for accessibility issues N/A
  • Includes documentation
  • User-facing strings are extracted for translation

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the conflicts are resolved 👍

@Ian2012 Ian2012 merged commit 8eb022c into main Mar 5, 2024
7 checks passed
@Ian2012 Ian2012 deleted the cag/import-sink branch March 5, 2024 15:39
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants