-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import event-sink-clickhouse plugin #3
Conversation
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this on my tutor dev stack by overriding this setting from Aspects, and testing to make sure events still appear in Superset as expected:
OPENEDX_EXTRA_PIP_REQUIREMENTS: - git+https://github.com/openedx/platform-plugin-aspects.git@cag/import-sink#egg=platform_plugin_aspects - "edx-event-routing-backends==v8.1.1"
- I skimmed through the code -- didn't read in detail since this is just a copy-over.
-
I checked for accessibility issuesN/A - Includes documentation
- User-facing strings are extracted for translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once the conflicts are resolved 👍
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR imports the code from the openedx-event-sink-clickhouse repository.