Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a check to ensure the committers-at-large team has access. #584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions edx_repo_tools/repo_checks/repo_checks.py
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,22 @@ def is_relevant(self):
return is_public(self.api, self.org_name, self.repo_name)


@Check.register
class MaintainersAtLargeTeam(TeamAccess):
"""
Ensure that the committers-maintainers-at-large team grants Push access to every public repo in the org.
"""

def __init__(self, api, org, repo):
team = "committers-maintainers-at-large"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mouthful but I felt that having it just be committers-at-large could be misconstrued as these users can merge whatever they want and not just maintenance related work.

permission = "push"
super().__init__(api, org, repo, team, permission)

def is_relevant(self):
# Need to be a public repo.
return is_public(self.api, self.org_name, self.repo_name)


@Check.register
class EnforceCLA(Check):
"""
Expand Down
Loading