Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use extended block names in instructor dashboard (FC-0033) #476

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

SoryRawyer
Copy link
Contributor

This change updates Superset assets to use the new dbt models that include block display names with location information. This includes the video and problem filters as well as the values returned by course-level charts. The screenshots below show an example of the new format.

Using new display names in charts:
Screenshot from 2023-10-17 14-45-05

Using new display names in filters:
Screenshot from 2023-10-17 14-45-19

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 17, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012
Copy link
Contributor

Ian2012 commented Oct 17, 2023

@bmtcril is this the desired behavior?

I tough it would a larger problem/video selector field, not an index

Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bmtcril
Copy link
Contributor

bmtcril commented Oct 18, 2023

@Ian2012 this is what we came to as a solution in the demo, the instructor was confused by the ordering of blocks and wanted them in the order that they appear in the course. Similarly they didn't always know the names of blocks (or had the same name for numerous blocks) and wanted to be able to identify it in the course. So I think this solves for both of those things. I'd like to get it into the beta and gather more feedback there.

@bmtcril bmtcril merged commit 319decc into openedx:main Oct 18, 2023
5 checks passed
@openedx-webhooks
Copy link

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants