-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add all default assets to aspects-superset image to avoid load it via larger file #500
Conversation
Thanks for the pull request, @Henrrypg! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@Ian2012 Can you please take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sql files can be removed from the docker image and can live only in the plugin templates.
tutoraspects/templates/aspects/apps/superset/pythonpath/create_assets.py
Outdated
Show resolved
Hide resolved
tutoraspects/templates/aspects/apps/superset/pythonpath/create_assets.py
Show resolved
Hide resolved
tutoraspects/templates/aspects/apps/superset/pythonpath/create_assets.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmtcril do you want to take a look?
@pomegranited you can rebase over this changes on your PR
tutoraspects/templates/aspects/apps/superset/pythonpath/test.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one question. We should also update documentation to indicate that any time an asset or translation change is made we will need to rebuild the image before re-running init to test now.
f6fecc5
to
90903c3
Compare
@bmtcril why translations? Those are still loaded from a config file |
@Ian2012 true, but I think the point about assets still stands |
93f9614
to
a117754
Compare
a117754
to
ef520eb
Compare
@Henrrypg the error is caused by a flaky migration in Superset. The workflow is re run |
1 similar comment
@Henrrypg the error is caused by a flaky migration in Superset. The workflow is re run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bah sorry, I merged another PR before this one. You'll need to rebase and probably move the new files over to the new location. This looks ready to merge once that's done, though.
ef520eb
to
1d017c2
Compare
@Henrrypg 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR intends to modify
aspects-superset
image to contains all defaultopenedx-assets
and load it from there, and still load custom assets with the patch oversuperset-extra-assets
. This changes will keep a smallassets.yaml
file and ConfigMap for K8S,How to test it
You should run an openedx environment from cero without any problem in the init.