Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ClickHouse system metrics to the Operator Dashboard's Clickhouse tab #503

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Adds ClickHouse system metrics to the Operator Dashboard's Clickhouse tab #503

merged 1 commit into from
Nov 1, 2023

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Nov 1, 2023 •
edited
Loading

Added a ClickHouse Metrics table which combines queries from Altinity: Clickhouse Monitoring into a single name/value/description table.

clickhouse_metrics

Addresses #427 (comment)

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 1, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 1, 2023 •
edited
Loading

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@pomegranited pomegranited requested a review from bmtcril November 1, 2023 02:02
@pomegranited pomegranited marked this pull request as draft November 1, 2023 02:33
@pomegranited pomegranited force-pushed the jill/clickhouse-metrics branch from c8f99da to 5af67af Compare November 1, 2023 04:02
@pomegranited pomegranited marked this pull request as ready for review November 1, 2023 04:03
bmtcril
bmtcril approved these changes Nov 1, 2023
View reviewed changes
tutoraspects/templates/openedx-assets/assets/datasets/clickhouse_computed_metrics.yaml
SELECT
'StuckReplicationTasks' AS name,
toFloat64(count()) AS value,
'Replication tasks that were retried or postponed over 100 times.' AS description
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat concerned that we won't be able to translate these descriptions, but we have another task to look at how to make that work so it's non-blocking.

@bmtcril bmtcril merged commit 23389bf into main Nov 1, 2023
5 checks passed
@bmtcril bmtcril deleted the jill/clickhouse-metrics branch November 1, 2023 14:38
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

@Ian2012 Ian2012 Ian2012 approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pomegranited @openedx-webhooks @Ian2012 @bmtcril @itsjeyd