Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tutor variables to expose clickhouse container ports in k8s #524

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

pomegranited
Copy link
Contributor

Description

Updates the k8s configuration to use Tutor variables when exposing the Clickhouse container ports.

Related information

Closes #387

@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 22, 2023
Comment on lines 34 to 35
- containerPort: "{{ CLICKHOUSE_HOST_INSECURE_NATIVE_PORT }}"
- containerPort: "{{ CLICKHOUSE_HOST_TLS_NATIVE_PORT }}"
Copy link
Contributor Author

@pomegranited pomegranited Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the default values for these variables differ from what was hardcoded here, so operators may need to update their configurations.

The default values are:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your 👍 @Ian2012 -- do you have any concerns about the port changes here, since you guys are running Aspects in production?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are running Aspects with Clickhouse outside the cluster. I think it's safe to make the change

@pomegranited pomegranited requested a review from bmtcril November 22, 2023 04:11
@Ian2012 Ian2012 merged commit c547efd into main Nov 23, 2023
5 checks passed
@Ian2012 Ian2012 deleted the jill/ch-ports branch November 23, 2023 03:21
@openedx-webhooks
Copy link

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: ClickHouse container ports hard coded in K8s deployment
4 participants