-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use tutor variables to expose clickhouse container ports in k8s #524
Conversation
Thanks for the pull request, @pomegranited! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
tutoraspects/patches/k8s-deployments
Outdated
- containerPort: "{{ CLICKHOUSE_HOST_INSECURE_NATIVE_PORT }}" | ||
- containerPort: "{{ CLICKHOUSE_HOST_TLS_NATIVE_PORT }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the default values for these variables differ from what was hardcoded here, so operators may need to update their configurations.
The default values are:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your 👍 @Ian2012 -- do you have any concerns about the port changes here, since you guys are running Aspects in production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are running Aspects with Clickhouse outside the cluster. I think it's safe to make the change
@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
Updates the k8s configuration to use Tutor variables when exposing the Clickhouse container ports.
Related information
Closes #387