Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import databases from settings #581

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: import databases from settings #581

merged 2 commits into from
Jan 30, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Jan 29, 2024

Description

This PR allows developers to not need to build the Superset image if the assets and other settings match the defaults. This allows to easily tests Aspects without the need to build the Superset image on any single change

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 29, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/database-connection branch 2 times, most recently from 8026390 to 562c4b3 Compare January 30, 2024 15:43
@Ian2012 Ian2012 marked this pull request as draft January 30, 2024 16:02
@Ian2012 Ian2012 force-pushed the cag/database-connection branch from 562c4b3 to a971529 Compare January 30, 2024 16:58
@Ian2012 Ian2012 marked this pull request as ready for review January 30, 2024 16:58
@Ian2012 Ian2012 merged commit 3118191 into main Jan 30, 2024
6 checks passed
@Ian2012 Ian2012 deleted the cag/database-connection branch January 30, 2024 17:22
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants