Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for data pipeline load testing #675

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

bmtcril
Copy link
Contributor

@bmtcril bmtcril commented Mar 21, 2024

No description provided.

@bmtcril bmtcril force-pushed the bmtcril/load_test branch from b42951d to a5906fe Compare April 1, 2024 17:05
@bmtcril bmtcril marked this pull request as ready for review April 1, 2024 20:41
@@ -136,6 +137,8 @@
("ASPECTS_EVENT_SINK_RECENT_BLOCKS_MV", "most_recent_course_blocks_mv"),
# Vector settings
("ASPECTS_DOCKER_HOST_SOCK_PATH", "/var/run/docker.sock"),
("ASPECTS_VECTOR_STORE_TRACKING_LOGS", False),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These settings are new and let us turn on and off each piece of the Vector storage individually.

.. pii: Stores Open edX user profile data.
.. pii_types: user_id, name, username, location, phone_number, email_address, birth_date, biography, gender
.. pii_retirement: local_api, consumer_api
Partition the xapi table by year and month
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in this file is just cleaning up incorrect language from the original commit.

@@ -3,4 +3,4 @@ data_dir = "/vector-data-dir"
# Vector's API for introspection
[api]
enabled = true
address = "127.0.0.1:8686"
address = "0.0.0.0:8686"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed to support the load test scripts hitting the Vector API, but it should still not be available outside of the cluster unless someone configures it that way on purpose.

@Ian2012 Ian2012 merged commit 9d8f75a into main Apr 2, 2024
9 checks passed
@Ian2012 Ian2012 deleted the bmtcril/load_test branch April 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants