Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto delete old charts #941

Closed
wants to merge 3 commits into from

Conversation

saraburns1
Copy link
Contributor

Closes #370

Output when importing zips
Screenshot 2024-09-13 at 10 47 38 AM
Screenshot 2024-09-13 at 10 47 53 AM

@bmtcril
Copy link
Contributor

bmtcril commented Sep 13, 2024

Nice, I'm glad you're tackling this! Once concern that I tried to raise in the original ticket is that we can't assume that any assets in Superset that aren't current Aspects assets should be deleted (like custom charts and dashboards) so we need some kind of way to say "this asset uuid is a deleted Aspects asset from the past that should be cleaned up".

@saraburns1
Copy link
Contributor Author

Nice, I'm glad you're tackling this! Once concern that I tried to raise in the original ticket is that we can't assume that any assets in Superset that aren't current Aspects assets should be deleted (like custom charts and dashboards) so we need some kind of way to say "this asset uuid is a deleted Aspects asset from the past that should be cleaned up".

could we instead have a file that keeps a list of unused assets that we DONT want to delete? that might be easier to maintain than a list of ones TO delete

@bmtcril
Copy link
Contributor

bmtcril commented Sep 13, 2024

I don't think we have a way of knowing which custom assets someone added are unused / deletable. We can only know our own assets, so we could put a check in CI or something that would fail a build if there were unused assets left in our changes. Then we could add them to the list. Seems kind of error prone, but if we put the reminder to add them to the list in the error message it might help?

@saraburns1
Copy link
Contributor Author

Ahhh makes sense. Cool, I'll do that

@saraburns1 saraburns1 closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Delete known-orphaned Superset assets
2 participants