Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test failure] TC_AUTHOR_142: Certificate preview not showing signatures #364

Open
alexjmpb opened this issue May 23, 2024 · 6 comments
Open
Labels
bug Report of or fix for something that isn't working as intended redwood release testing Affects the upcoming release (attention needed) sumac
Milestone

Comments

@alexjmpb
Copy link

Release

Redwood

Expected behavior

"1. Go to a course with a certificate already set up
2. Preview certificate
3. Select print option. The layout (signatures, course name, ID, org...) are in place"

Actual behavior

The printing layout is correct overall except for the signatures which are not showing up.

Steps to reproduce

"1. Go to a course with a certificate already set up
2. Preview certificate
3. Review that signatures are not showing.

Additional information

image

image

This test case is indicated that also failed in Quince.

@mariajgrimaldi mariajgrimaldi added the release testing Affects the upcoming release (attention needed) label May 23, 2024
@mariajgrimaldi
Copy link
Member

mariajgrimaldi commented May 23, 2024

Hello. Thank you for the report!

I reported this issue a while ago: #177 (comment). In Quince, it was marked as failing, but it actually wasn't: #332 (comment). Honor code certificates use the organization logo and signatory information, but do not include signature images, which are used only for verified certificates.

As you mentioned, I tested it out on the sandbox with the verified course mode, and this time it didn't work for honor or verified.

After trying a few things, I noticed you didn't have any signature images in your setup so I added them, and it worked: https://redwood.demo.edly.io/certificates/course/course-v1:Test+1+1?preview=verified, for both honor and verified. I'm not sure if this is the usual behavior though. I'll test in a quince environment to confirm.

@mariajgrimaldi
Copy link
Member

The behavior I reported also happens in quince, but since signatures are optional, it's a bit misleading. I'll report this elsewhere.

@mariajgrimaldi
Copy link
Member

I reported this in the #redwood_release_planning slack channel: https://openedx.slack.com/archives/C06AMDA6CAZ/p1716551180358129

@jmakowski1123
Copy link

I would characterize this as a bug. I would expect the signatory info to display independently of the uploaded image. @cablaa77 - are you familiar with the intended certificate function?

@mariajgrimaldi mariajgrimaldi added this to the Redwood.1 milestone May 24, 2024
@mariajgrimaldi mariajgrimaldi added the bug Report of or fix for something that isn't working as intended label May 24, 2024
@mariajgrimaldi mariajgrimaldi self-assigned this May 24, 2024
@mariajgrimaldi
Copy link
Member

I'll be taking a look into this. I'll make sure to report back once I know more. Thank you!

@mariajgrimaldi mariajgrimaldi moved this from In progress to Backlog in Build-Test-Release Working Group Aug 13, 2024
@mariajgrimaldi mariajgrimaldi removed their assignment Aug 13, 2024
@mariajgrimaldi
Copy link
Member

I haven't had time to work on this so I'll unassign myself for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended redwood release testing Affects the upcoming release (attention needed) sumac
Projects
Status: Backlog
Development

No branches or pull requests

4 participants