Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data too long for column 'resource_id' #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Faraz32123
Copy link

when the course id is a little bit long, the lti xblock id becomes too long for resource_id to handle

To reproduce:

  • Create a course with long ID. For example: course-v1:Public+TEST_IT_01+TEST_IT_01_Dec_2023
  • Add lti_consumer in Advanced settings for the course
  • Try to add an LTI component in the course with version 1.3
  • The unit crashes
    I have tested it locally
Screenshot 2024-12-27 at 11 56 37 AM

Muhammad Faraz Maqsood and others added 2 commits December 27, 2024 12:59
when the course id is a little bit long, the lti xblock id becomes too long for resource_id to handle
@Faraz32123
Copy link
Author

@feanil can u look into this PR and merge it. Thanks.

@Faraz32123 Faraz32123 requested a review from feanil December 27, 2024 08:12
@Faraz32123 Faraz32123 changed the title Fix/short resource fix: Data too long for column 'resource_id' Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants