Skip to content

Commit

Permalink
make django version in >=1.8,<1.9
Browse files Browse the repository at this point in the history
  • Loading branch information
@muhammad-ammar
muhammad-ammar committed Nov 6, 2015
1 parent eae8ecd commit 766c0fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion requirements/base.txt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cookiecutter==0.9.0
Django==1.8.4
Django>=1.8,<1.9

This comment has been minimized.

Sign in to view

Copy link
@muhammad-ammar

muhammad-ammar Nov 6, 2015

Author Contributor

@nedbat Any particular reason for pinning django==1.8.4. Due to this fixed version edx-ora2 tests were failing. I have made it flexible, now edx-ora2 tests are passing but xblock-sdk build is failing.

This comment has been minimized.

Sign in to view

Copy link
@nedbat

nedbat Nov 9, 2015

Contributor

I'd like to understand this problem. My theory is this, and any part of it could be wrong:

  1. Repos are either libraries, or applications, and not both.
  2. Applications should pin versions, libraries should not.
  3. Every application should be run in its own virtualenv, so that their versions won't fight with each other.
  4. XBlock-SDK is an application.
  5. edx-ora2 is a library.
lxml
requests
webob
Expand Down

0 comments on commit 766c0fa

Please sign in to comment.