Updated Dockerfile and Pipfile.lock and fixed tests #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssuffian
force-pushed
the
update-docker-and-dependencies
branch
from
d62ba6b to
6e28565
Compare
ssuffian
requested review from
philngo-recurve and
jglasskatz
and removed request for
jglasskatz
changes in updated dependencies, and fixed a bug with the sample data. - pandas dataframes .sum().sum() no longer sum Categorical type values. - sample data was loading in with a `usage_per_day` column that needs to be `meter_value`. Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
Signed-off-by: Stephen Suffian <[email protected]>
ssuffian
force-pushed
the
update-docker-and-dependencies
branch
from
f6c6a35 to
d90999c
Compare
jason-recurve
approved these changes
Mar 7, 2023
philngo-recurve
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updates to the Dockerfile and Pipfile.lock led to the need to change a few of the pytests, although it doesn't appear to have changed any of the underlying code. The primary change that affected tests was that pandas dataframes .sum().sum() no longer sum Categorical type values.
Also, the newer jupyterlab version requires rust, so a rust installation is now included in the Dockerfile.
I also found that the sample data CLI wasn't working, which seems unrelated to the updated dependencies and instead due to a column name issue. The sample data was loading in with a
usage_per_daycolumn that needed to instead bemeter_value. I think this is the issue that was referenced here (and is now fixed in this PR): #377Signed-off-by: Stephen Suffian [email protected]
Your checklist for this pull request
Please review the guidelines for contributing to this repository.
docker-compose run --rm test.docker-compose run --rm blacken.included in docs/api.rst for the sphinx build. Please use numpy-style docstrings.
Sphinx docs can be built with the following command:
docker-compose run --rm --entrypoint="make -C docs html" shell. Please note and fix any warnings.the Developer Certificate of Origin. When you're making a commit, just add
the
-s/--signoffflag (e.g.,git commit -s).Description
Please describe your pull request.