-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added F# template #86
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Peder Husom <[email protected]>
Hi @hayer Since you built your template we've upped the security requirements on the default OpenFaaS configuration. You'll need to update your template to use a non-root user and ideally pull in the watchdog binary via a multi-stage build. Please have a look at how we did it for the "csharp" template in the openfaas/templates repo |
@alexellis updated the Dockerfile now. |
Please just do the following now for merge:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes needed
Hello @hayer! I know it's been a little while, but would you be able to complete the final steps to getting this merged? It'd be best to have a sample function in the readme file to demonstrate how to write a function using your template. Also, there is now a conflict in the Let me know if you need any help, or have any questions! |
Having a clear-up on GitHub issues / PRs over 1 month old. Let's revisit as necessary. Thank you for the PR. |
Will take a look this weekend. Sorry for the delay. |
Added my F# template to the templates.json list, #64.