Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add time spent tracking to tuple write command #450

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

Siddhant-K-code
Copy link
Contributor

@Siddhant-K-code Siddhant-K-code commented Feb 5, 2025

Description

This PR adds time tracking functionality to the tuple write command, displaying how long operations take to complete using Go's standard duration formatting.

Example output:

{
  "failed_count": 1,
  "successful_count": 1,
  "total_count": 2,
  "time_spent": "2.976ms"
}

References

fixes #448

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@Siddhant-K-code Siddhant-K-code requested a review from a team as a code owner February 5, 2025 09:53
cmd/tuple/write.go Outdated Show resolved Hide resolved
cmd/tuple/write.go Outdated Show resolved Hide resolved
@Siddhant-K-code
Copy link
Contributor Author

@ewanharris, it looks good to go now 🚀


Regarding Squashing commits, I think, we can do that while merging PR from GitHub UI by selecting Squash & Merge option

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Siddhant-K-code! 🚀

@ewanharris ewanharris added this pull request to the merge queue Feb 10, 2025
Merged via the queue into openfga:main with commit 31ea381 Feb 10, 2025
15 checks passed
@Siddhant-K-code Siddhant-K-code deleted the feat/448 branch February 10, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display "time spent" in the tuple write/delete commands
2 participants