Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add synonyms to useUrlParams #540

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Add synonyms to useUrlParams #540

merged 4 commits into from
Feb 13, 2023

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Feb 12, 2023 •
edited
Loading

Solves openfoodfacts/facets-knowledge-panels#80

@sumit-158 You can now (after PR merge of course 😉) use value_tag in all urls. Is there other parameters that are problematic?

@alexfauquette alexfauquette requested a review from a team as a code owner February 12, 2023 19:58
@sumit-158
Copy link
Member

Thank you @alexfauquette ! 🙏🚀

@sumit-158
Copy link
Member

sumit-158 commented Feb 13, 2023 •
edited
Loading

Is there other parameters that are problematic?

Nope 👍

@alexfauquette alexfauquette merged commit 1373651 into openfoodfacts:master Feb 13, 2023
@alexfauquette alexfauquette deleted the fix-urlParams branch February 13, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexfauquette alexfauquette

Labels
insights 🖼️ Logo game
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfauquette @sumit-158