Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade to falcon 3.X #1296

Merged
merged 2 commits into from
Dec 7, 2023
Merged

refactor: upgrade to falcon 3.X #1296

merged 2 commits into from
Dec 7, 2023

Conversation

raphael0202
Copy link
Collaborator

@raphael0202 raphael0202 commented Dec 4, 2023

  • switch to falcon 3.1. It has better exception handling, and supports more recent versions of Python officially.
  • add auto-reload support for gunicorn, and enable it during dev by default

@raphael0202 raphael0202 changed the title fix: handle internal error and return HTTP 500 fix: upgrade to falcon 3.X Dec 7, 2023
@raphael0202 raphael0202 changed the title fix: upgrade to falcon 3.X refactor: upgrade to falcon 3.X Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (c77f049) 57.45% compared to head (6f7f7a5) 57.43%.

Files Patch % Lines
robotoff/app/api.py 38.09% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
- Coverage   57.45%   57.43%   -0.03%     
==========================================
  Files          79       79              
  Lines        7778     7783       +5     
==========================================
+ Hits         4469     4470       +1     
- Misses       3309     3313       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 marked this pull request as ready for review December 7, 2023 10:09
@raphael0202 raphael0202 requested a review from a team as a code owner December 7, 2023 10:09
@raphael0202 raphael0202 merged commit a1ffa44 into main Dec 7, 2023
8 of 10 checks passed
@raphael0202 raphael0202 deleted the add-exc-handler branch December 7, 2023 10:39
@alexgarel
Copy link
Member

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants