Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the absence of matching synonyms during category insight import #1497

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

raphael0202
Copy link
Collaborator

  • use create_taxonomy_mapping from SDK
  • use taxonomy_mapping for categories to match the canonical ID

- use create_taxonomy_mapping from SDK
- use taxonomy_mapping for categories to match the canonical ID
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.54%. Comparing base (fb6c5dc) to head (424796f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
robotoff/insights/importer.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1497      +/-   ##
==========================================
- Coverage   55.56%   55.54%   -0.02%     
==========================================
  Files          85       85              
  Lines        8739     8740       +1     
==========================================
- Hits         4856     4855       -1     
- Misses       3883     3885       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 merged commit 66c5322 into main Dec 12, 2024
9 checks passed
@raphael0202 raphael0202 deleted the fix-match-taxonomy-value branch December 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant