Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update count and refacto code with Signal #203

Merged
merged 8 commits into from
Jul 8, 2024
Merged

feat: update count and refacto code with Signal #203

merged 8 commits into from
Jul 8, 2024

Conversation

Kout95
Copy link
Collaborator

@Kout95 Kout95 commented Jun 28, 2024 •
edited
Loading

What

  • Refacto code to use signal instead of events to simplify code
  • Update count to display "More than" if it is not an exact count
  • Allow to Display time of search by default it is false

Screenshot

image

Part of

@Kout95 Kout95 requested a review from alexgarel July 1, 2024 07:04
@Kout95 Kout95 marked this pull request as ready for review July 1, 2024 07:10
alexgarel
alexgarel approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR !

Some suggestions before merging !

frontend/src/search-count.ts Outdated Show resolved Hide resolved
frontend/src/search-count.ts Show resolved Hide resolved
frontend/src/search-count.ts Outdated Show resolved Hide resolved
frontend/src/signals.ts Show resolved Hide resolved
frontend/src/signals.ts Show resolved Hide resolved
frontend/src/signals.ts Show resolved Hide resolved
frontend/src/signals.ts Outdated Show resolved Hide resolved
frontend/src/test/utils.ts Show resolved Hide resolved
@Kout95 Kout95 merged commit 9fbec21 into main Jul 8, 2024
5 of 6 checks passed
@Kout95 Kout95 deleted the update-count branch July 8, 2024 09:30
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jul 8, 2024
Merged
@alexgarel alexgarel mentioned this pull request Jul 12, 2024
Closed
2 tasks
alexgarel pushed a commit that referenced this pull request Jul 25, 2024
@openfoodfacts-bot
chore(main): release 1.4.0 (#210)
c495b10 
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](v1.3.0...v1.4.0)
(2024-07-25)


### Features

* add default images for products without image in off.html
[#208](#208)
([#220](#220))
([e4456f3](e4456f3))
* add loader in search-results
([#209](#209))
([0ee92b5](0ee92b5))
* be able to create scatter plots
([#189](#189))
([92e1c1b](92e1c1b))
* hide chart when search is not launched
([#214](#214))
([468a4c6](468a4c6))
* update count and refacto code with Signal
([#203](#203))
([9fbec21](9fbec21))


### Bug Fixes

* move docs and fix content
([#215](#215))
([2bc06c3](2bc06c3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@Kout95 Kout95

Labels
None yet
Projects
🔎 Search-a-licious
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kout95 @alexgarel