Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore existing Robotoff questions when reloading #6130

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 6, 2025

Hi everyone!

My previous PR (#6078) was not strict enough to remove the Robotoff banner.
Basically, if the API still returns the same questions, the banner will reappear.

We now ensure that after answering questions AND if questions are the same, the banner won't be displayed.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 6.38%. Comparing base (4d9c7fc) to head (8615991).
Report is 612 commits behind head on develop.

Files with missing lines Patch % Lines
...ooth_app/lib/helpers/robotoff_question_helper.dart 0.00% 9 Missing ⚠️
...b/pages/product/product_page/new_product_page.dart 0.00% 7 Missing ⚠️
...pp/lib/pages/product/product_questions_widget.dart 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6130      +/-   ##
==========================================
- Coverage     9.54%   6.38%   -3.17%     
==========================================
  Files          325     449     +124     
  Lines        16411   25515    +9104     
==========================================
+ Hits          1567    1628      +61     
- Misses       14844   23887    +9043     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Edouard 👍

@teolemon teolemon merged commit 1f8f66c into openfoodfacts:develop Jan 6, 2025
6 checks passed
@g123k g123k deleted the robotoff_questions2 branch January 6, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The robotoff dismiss system is not working well in some conditions
3 participants