Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Brands edition in a list + reorderable items #6167

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 9, 2025

Hi everyone!

This PR will finally resolve the issue with autocompletion on multiple brands.
The brands are displayed in a list and are even reorderable.

Video:

ScreenRecording_01-09-2025.20-39-24_1.MP4

New feature when editing

For all fields, adding an existing value will display an error VS nothing before
IMG_1759

@github-actions github-actions bot added 🥫 Product page 🌐 l10n ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✏️ Editing - Basic info input labels Jan 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 141 lines in your changes missing coverage. Please review.

Project coverage is 6.32%. Comparing base (4d9c7fc) to head (9c62964).
Report is 630 commits behind head on develop.

Files with missing lines Patch % Lines
...oth_app/lib/pages/product/simple_input_widget.dart 0.00% 67 Missing ⚠️
...p/lib/pages/product/simple_input_page_helpers.dart 0.00% 44 Missing ⚠️
..._app/lib/pages/product/add_basic_details_page.dart 0.00% 18 Missing ⚠️
...app/lib/pages/product/simple_input_text_field.dart 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6167      +/-   ##
==========================================
- Coverage     9.54%   6.32%   -3.23%     
==========================================
  Files          325     451     +126     
  Lines        16411   26014    +9603     
==========================================
+ Hits          1567    1645      +78     
- Misses       14844   24369    +9525     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing - Basic info input ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users 🌐 l10n 🥫 Product page
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

2 participants