✨(backend) add start and end date on OrderGroup model #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanreveille
force-pushed
the
feat/add_start_and_end_date_to_ordergroup_model
branch
2 times, most recently
from
900f92a to
b844aa3
Compare
kernicPanel
reviewed
Jan 30, 2025
Comment on lines
388
to
394
| models.CheckConstraint( | ||
| check=~models.Q(start__isnull=True) ^ models.Q(end__isnull=True), | ||
| name="both_start_and_end_dates_must_be_set_or_neither", | ||
| violation_error_message=_( | ||
| "Both start and end dates must be set, or neither." | ||
| ), | ||
| ), |
There was a problem hiding this comment.
I'm wondering if we need this rule. We should talk bout it IRL.
There was a problem hiding this comment.
as seen in IRL, we will take away this model constraint because we will use those fields for :
- 🐦 early birds : set the end date only
- ⌛ last minute : set the beginning date only
Concerning the field is_active on OrderGroup model :
- refer to
is_activevalue in database ifstartnorenddatetime are setted. - calculate through the
OrderGroupSerializerandAdminOrderGroupSerializerthe fieldis_activeif either start or end or both datetimes are setted.
There was a problem hiding this comment.
REVIEWING COMMENT : (WIP)
...
- 🐦 early birds : set the end date only (en fonction de la date d'ouverture et la date de fin du groupe)
- ⌛ last minute : set the beginning date only (en fonction de la date de cloture du cours)
...
jonathanreveille
force-pushed
the
feat/add_start_and_end_date_to_ordergroup_model
branch
from
4b48e0b to
b48a129
Compare
We want to be able to define a starting and ending date on order groups. This will allow to use them as promotional sessions on a given course with a fix number of available seats. For now, order groups work just as before, but if you define a starting date, you should define also an ending date of validity.
jonathanreveille
force-pushed
the
feat/add_start_and_end_date_to_ordergroup_model
branch
from
b48a129 to
5355f60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to define a starting and ending date on order groups. This will allow to use them as promotional sessions on a given course with a fix number of available seats.
For now, order groups work just as before, but if you define a starting date, you should define also an ending date of validity. They are either both set, or neither.
The start date cannot be greater than the end date.
Proposal
startandenddatetime fields onOrderGroupmodel