🐛(backend) fix installment update #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernicPanel
force-pushed
the
fix-installment-update-2-try
branch
3 times, most recently
from
b538b06 to
cb4794e
Compare
jbpenrath
reviewed
Feb 3, 2025
| self._do_on_payment_failure(order, installment["id"]) | ||
| return False | ||
|
|
||
| order.set_installment_refused(installment["id"]) |
There was a problem hiding this comment.
I wonder if we should not continue to set the installment to refused state only if an UNPAID transaction is found. But we should continue to iterate over the transactions list.
Actually, if a transaction has never been debited, its state will be set to refused first.
| # Mail is sent | ||
| self._check_installment_refused_email_sent(owner.email, order) | ||
| # No mail is sent | ||
| self.assertEqual(mail.outbox, []) | ||
|
|
||
| mail.outbox.clear() |
There was a problem hiding this comment.
Can we take away this line too ?
mail.outbox.clear()
jonathanreveille
approved these changes
Feb 3, 2025
jbpenrath
approved these changes
Feb 3, 2025
| json_response["answer"]["transactions"].append( | ||
| json_response["answer"]["transactions"][0] | ||
| ) | ||
| json_response["answer"]["transactions"] = [] |
There was a problem hiding this comment.
Suggested change
| json_response["answer"]["transactions"].append( | |
| json_response["answer"]["transactions"][0] | |
| ) | |
| json_response["answer"]["transactions"] = [] | |
| json_response["answer"]["transactions"] = [] |
Comment on lines
2235
to
2237
| When backend checks if an installment has already been paid, it should return True | ||
| if the payment has been made and should update the installment state to paid. | ||
| Last transaction is paid. |
There was a problem hiding this comment.
Suggested change
| When backend checks if an installment has already been paid, it should return True | |
| if the payment has been made and should update the installment state to paid. | |
| Last transaction is paid. | |
| When backend checks if an installment has already been paid, it should return False | |
| if the no payment has been made and should not update the installment state. | |
| No transaction paid. |
When we check for installemnt payment after retrying, only the first transaction was taken into account.
kernicPanel
force-pushed
the
fix-installment-update-2-try
branch
from
9a95030 to
cc4e48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When we check for installemnt payment after retrying, only the first transaction was taken into account.