Skip to content

Commit

Permalink
Add a couple to-do items.
Browse files Browse the repository at this point in the history
  • Loading branch information
LswaN58 committed Dec 1, 2024
1 parent d68be73 commit 1f4e761
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/ogd/common/models/FeatureData.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@
from ogd.common.models.enums.ExtractionMode import ExtractionMode

class FeatureData(GameData):
"""
.. todo:: Add element to track the feature extractor version in some way.
:param GameData: _description_
:type GameData: _type_
"""
def __init__(self, name:str, feature_type:str, count_index:Optional[int],
cols:List[str], vals:List[Any], mode:ExtractionMode,
app_id:str, user_id:Optional[str], session_id:str,
Expand Down
1 change: 1 addition & 0 deletions src/ogd/common/models/GameData.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def ColumnValues(self) -> List[Union[str, datetime, timezone, Map, int, None]]:
"""A list of all values for the row, in order they appear in the `ColumnNames` function.
.. todo:: Technically, this should be string representations of each, but we're technically not enforcing that yet.
.. todo:: Currently assuming a single app/log version, but theoretically we could, for example, have multiple app versions show up in a single population. Need to handle this, e.g. allow a list.
:return: The list of values.
:rtype: List[Union[str, datetime, timezone, Map, int, None]]
Expand Down

0 comments on commit 1f4e761

Please sign in to comment.