Refactor interface classes: phase 1 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add documentation to IDMode, from core branch.
…tting list of IDs.
…attached to GameSourceSchema.
…ing it at INFO level.
…ead of DataSourceSchema as parent.
… corresponding testbeds.
Separate `configs` module from `schemas`
…it a straight-up type alias instead.
LswaN58
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a significant step towards the ideas documented in #61. However, work still remains in order to finish restructuring configs and ultimately implementing the updated interfaces/outerfaces. Merging before completion because the project has grown well beyond the scope of the original single branch in which many related but distinct changes were made.
Resolves #3
Resolves #45
Resolves #54