Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split TableSchema to structure and location #72

Merged
merged 13 commits into from
Jan 8, 2025
Merged

Split TableSchema to structure and location #72

merged 13 commits into from
Jan 8, 2025

Conversation

LswaN58
Copy link
Member

@LswaN58 LswaN58 commented Jan 8, 2025

Resolves #69

LswaN58 added 13 commits January 7, 2025 19:05
@LswaN58
Rename existing 'table schema' classes to be table 'structure' schemas.
8ac24e4
@LswaN58
Give table structure schemas to own folder.
fabc944
@LswaN58
Folder should have an init.
5920529
@LswaN58
Move contents of old tables init to the structures init.
3a23cc9
@LswaN58
Add basic placeholder class for TableLocationSchema base class, which…
be29726 
… just holds a table name.
@LswaN58
Move ColumnSchema and ElementMappingSchema into structures part as well.
b62c7ef
@LswaN58
Update import paths for ColumnSchema. ElementMappingSchema appears no…
fdd9c43 
…t to be in use.K
@LswaN58
Move class comment block to correct spot.
1c3a2ca
@LswaN58
Get most of the functions in place for the TableLocationSchema base c…
80c3f8c 
…lass.
@LswaN58
Get new TableSchema class in place, which has both table structure an…
54833da 
…d location schemas.
@LswaN58
Fix some import paths, and add better function docstring.
e8d3a3a
@LswaN58
Add prop for the Location schema, and add location to the Markdown prop.
fbb9168
@LswaN58
Need classmethod before abstractmethod for decorators.
788ba3f
@LswaN58 LswaN58 added config Improvements to configuration management refactor Moving code to a more suitable place labels Jan 8, 2025
@LswaN58 LswaN58 added this to the ogd-common 2.0 "refactor" milestone Jan 8, 2025
@LswaN58 LswaN58 self-assigned this Jan 8, 2025
@LswaN58 LswaN58 linked an issue Jan 8, 2025 that may be closed by this pull request
Split TableSchema to use structure and location schemas #69
Closed
@LswaN58 LswaN58 merged commit 52171f4 into main Jan 8, 2025
17 of 18 checks passed
@LswaN58 LswaN58 deleted the issue/69-split-tableschema-to-structure-and-location branch January 8, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@LswaN58 LswaN58

Labels
config Improvements to configuration management refactor Moving code to a more suitable place
Projects
None yet
Milestone
ogd-common 2.0 "refactor"
Development

Successfully merging this pull request may close these issues.

Split TableSchema to use structure and location schemas
1 participant
@LswaN58