Hilariously managed to do ternary operator backwards. Too much time d…

…oing it in Python.
opengamedata · Jun 5, 2024 · f8a37ac · f8a37ac
1 parent 4bf2e8b
commit f8a37ac
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/site/models/APIResponse.php b/site/models/APIResponse.php
@@ -15,19 +15,19 @@ public function __construct($type, $val, $msg, $status)
     }
 
     public static function fromObj($obj) {
-        $type   = $obj->{'type'}             ? isset($obj->{'type'})   : null;
-        $val    = json_decode($obj->{'val'}) ? isset($obj->{'val'})    : null;
-        $msg    = $obj->{'msg'}              ? isset($obj->{'msg'})    : null;
-        $status = $obj->{'status'}           ? isset($obj->{'status'}) : null;
+        $type   = isset($obj->{'type'})   ? $obj->{'type'}             : null;
+        $val    = isset($obj->{'val'})    ? json_decode($obj->{'val'}) : null;
+        $msg    = isset($obj->{'msg'})    ? $obj->{'msg'}              : null;
+        $status = isset($obj->{'status'}) ? $obj->{'status'}           : null;
         return new static($type, $val, $msg, $status);
     }
 
     public static function fromJson($json) {
         $obj = json_decode($json);
-        $type   = $obj->{'type'}             ? isset($obj->{'type'})   : null;
-        $val    = json_decode($obj->{'val'}) ? isset($obj->{'val'})    : null;
-        $msg    = $obj->{'msg'}              ? isset($obj->{'msg'})    : null;
-        $status = $obj->{'status'}           ? isset($obj->{'status'}) : null;
+        $type   = isset($obj->{'type'})   ? $obj->{'type'}             : null;
+        $val    = isset($obj->{'val'})    ? json_decode($obj->{'val'}) : null;
+        $msg    = isset($obj->{'msg'})    ? $obj->{'msg'}              : null;
+        $status = isset($obj->{'status'}) ? $obj->{'status'}           : null;
         return new static($type, $val, $msg, $status);
     }