Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform key on originals, add games #534

Merged
merged 9 commits into from
Dec 12, 2017
Merged

Conversation

nikuda
Copy link
Collaborator

@nikuda nikuda commented Dec 12, 2017

Closes #467 and others. See commit messages.

@slx7R4GDZM
Copy link
Contributor

https for Minetest links?

@nikuda
Copy link
Collaborator Author

nikuda commented Dec 12, 2017

Sure, updated.

@wonea wonea merged commit f0ea42e into opengaming:master Dec 12, 2017
'MS-DOS',
'Windows',
'OSX',
]
Copy link

@JayFoxRox JayFoxRox Jan 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This platform scheme is slightly confusing.

Which version of Windows for example. There is a big difference between Windows 3.1 or Windows 10. Also OSX is not really precise either - I intend to soon add a game which works on the old Mac OS (from 20 years ago) but not on newer macOS.

Also what's the difference between MS-DOS and just DOS? which version of a DOS?

Mobile is also kind of dangerous as Android also runs on TV sets etc. So putting Mobile can potentially break.

Either this should be more loose (e.g. device type this ran on to give people a rough idea) OR it should be more specific (so if people get rid of their old platform, they can look for alternative software).

In my opinion, it should also be considere to drop this field again altogether (and some others too) and to replace it with some existing database / upstream (like information stored on wikipedia, mobygames or some other source).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with some points, but this PR is already merged, so please create a new issue and continue this discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants