This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
2 new endpoints and a solved bug #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bartverhaar
commented
May 6, 2020
bartverhaar
commented
- Endpoint for OIV data
- Endpoint for authorized connection with geoserver
- Solved bug loosing password after chaning user
- solved bug password loss after changing a user - add endpoint for authorized connection with geoserver
matthijsln
suggested changes
May 14, 2020
| } | ||
|
|
||
| private static JSONArray objectsJson (Connection c) throws Exception { | ||
| List<Map<String,Object>> rows = DB.oivQr().query("select id " + |
| "from objecten.view_objectgegevens" | ||
| , new MapListHandler()); | ||
|
|
||
| Set<Integer> layerIds = new HashSet(DB.oivQr().query("select object_id " + |
| Integer object_id = (Integer)row.get("id"); | ||
| JSONObject object = rowToJson(row, true, true); | ||
| if(layerIds.contains(object_id)) { | ||
| object.put("heeft_verdiepingen", true); |
There was a problem hiding this comment.
Why not just do this in SQL?
| } | ||
|
|
||
| private static JSONObject objectJson (Connection c, int id) throws Exception { | ||
| List<Map<String,Object>> rows = DB.oivQr().query("select basic.id " + |
|
|
||
| private static JSONObject objectJson (Connection c, int id) throws Exception { | ||
| List<Map<String,Object>> rows = DB.oivQr().query("select basic.id " + | ||
| " , '' as oms_nummer " + |
There was a problem hiding this comment.
This huge SQL string is ugly, move to SQL
| } | ||
|
|
||
| out.flush(); | ||
| out.close(); |
| @@ -0,0 +1,2 @@ | |||
| ALTER TABLE organisation.wms ADD auth varchar NULL; | |||
There was a problem hiding this comment.
Security: this is leaked to the client in /viewer/api/organisation.json
| out += "&" + paramName + "="; | ||
| for (int i = 0; i < paramValues.length; i++) { | ||
| String paramValue = paramValues[i]; | ||
| out += paramValue; |
There was a problem hiding this comment.
Concatenating multiple parameter values is not how it works. This turns ?a=1&a=2&a=3 into a=123
| out += "&" + paramName + "="; | ||
| for (int i = 0; i < paramValues.length; i++) { | ||
| String paramValue = paramValues[i]; | ||
| out += paramValue; |
There was a problem hiding this comment.
This does not URL encode parameter values
| if(path != null) { | ||
| String geoserverUrl = handleParams(getContext().getRequest()).replace("&path=" + path + "&url=", ""); | ||
| URL url = new URL (geoserverUrl); | ||
| HttpURLConnection connection = (HttpURLConnection) url.openConnection(); |
There was a problem hiding this comment.
Security: this is an open proxy: /viewer/api/geoserver/get?url=https://www.google.com/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.